so unnecessary code

I’m currently (busy) working with a web UI for one project.
There’s nothing much complicated, just displaying a requested document in a web browser and provide a user a way to highlight some “interesting parts” of the document interactively.
Something like underline all the words with a specified category, or mark a set of words that are related to each other, or hide away sentences that are not very important. No need to calculate anything, all the information are provided in a requested document (XML).

I chose a mix of PHP, XSLT, and JavaScript to do this.
At the first place, I tried it with PHP and JavaScript with no XSLT.
But don’t like the idea to convert XML to HTML by PHP (or whatever language) coding. I just feel that it’s not safe to do so, in terms of long-term maintenance.
So I moved the conversion logic to XSLT, which is quite programming language neutral (depends on the availability of the XSL library).
We may drop the use of PHP at some point, but the conversion is still there in the stylesheet, which can be used by many programming languages.

Hope that’s a right decision.

After using XSLT, I had realized that, in fact, with the XSLT library in JavaScript (like one from Google Code), I can do everything I need by JavaScript.
Anyway, the library seems to be not very cross-browser.
So I just let the PHP do XSLT, also other backoffice stuffs, and let the JavaScript do the user interaction stuffs. Which is, so far, quite nice.

The problem is, I’m not a JavaScript master. My JavaScript code is ‘workable’ but far from ‘elegant’.

After a while, I found myself in a middle of repeated pieces of code.
Most of them are just a code to traverse around my DOM tree,
and all of these traverse codes in every functions are actually using the same logic.

There should be a more elegant way to do this.

I think it should be possible to abstract these following components away from each other:

  • traverse/looping
  • test logic
  • action to perform

something like:

(Note: the following code is just an idea, I’m pretty sure it’s not going to work.)


function process(objects, loop, test, trueAction, falseAction) {
  loop (objects, function (object) {
      if (test(object)) {
        if (trueAction)
          trueAction(object);
      } else {
        if (falseAction)
          falseAction(object);
      }
    });
}

function traverseEveryNode(nodes, perfomer) {
  for (node in nodes) { // just an example, the actual DOM is tree
    performer(node);
  }
}

and then you call:


process(dom, traverseEveryNode, isNoun, markYellow, false);

to paint yellow to all nouns in the given document. Given there’re functions named traverseEveryNode(), isNoun(), and markYellow().

How to do this in JavaScript ?

It seems like there’s something to do with a so-called “closure”.
But I still have no idea what it actually is at the moment — now reading.

If you have any clue, I’m very much appreciated to listen to 😉

Published by

bact

bact' is a name

3 thoughts on “so unnecessary code”

  1. อย่างนี้หรือเปล่า=====================var x = [1, 2, 3, 4, 5];function loop (ary, func) { for (i = 0; i < 5; i++) { func(ary[i]); }}function process (ary, loop, test, trueAction, falseAction) { var func = function innerTest (arg) { if (test(arg)) { trueAction(arg); } else { falseAction(arg); } } loop (ary, func);}var t = function test(arg) { if (arg == 3) { return true; } return false;}var tAct = function trueAction(arg) { println("yes");}var fAct = function falseAction(arg) { println("nop");}process(x, loop, test, tAct, fAct);=====================ใช้ JavaScript IDE test นะ ไม่ได้ลองบน browser engine

  2. โอ้ว์ โย่ว์ :)(บรรทัดสุดท้ายแก้ test เป็น t แล้วผ่านฉลุย)thx ครับ เดี๋ยวลองเล่นดู ;)คู่วว์

Leave a Reply